Advancement types aren't always the same

[TheLindblomer]

:information_source: Basic information

• Advanced Achievements version: 6.7.2
• Minecraft version: 1.16.4
• Wiki read: Yes
• Existing issues searched: Yes

:question: Help request

Hi! We're trying to figure out how the advancement function works as it's not being cooperative. Sometimes having "normal" doesn't work and it still displays as "rare" in both the advancements tab and in the pop-out notification when completing an achievement. Some are displayed correctly and some aren't so it's a little confusing. An image of how it looks like:

We've used the generate command and restarted the server without success.

Thank you in advance!

:wrench: Configuration

  secretFox:
    Goal: §6Someone's sleeping.
    Message: §7You found the foxxo!
    Name: secret_fox
    DisplayName: §6Sleeping fox
    Type: normal

[PyvesB]

Hello @TheLindblomer! 👋🏻

The Type parameter has no effect on the advancement tab, it is only used for the achievements in Advanced Achievements' own /aach list GUI.

Even in Minecraft's Vanilla advancement system, there are no such things as normal or rare advancements. Three advancement "frames" are available in the game:

• tasks: Advanced Achievements uses this frame for most advancements.
• challenges: Advanced Achievements uses this frame for the last, most difficult advancement in a category or sub-category.
• goals: Advanced Achievements only uses this frame for the base, parent advancement.

Hopefully this clarifies things!

[TheLindblomer]

Oh! Well, I feel dumb then. I suppose you can't change them in your plugin either? I kinda came across of this with the achievements in the "Commands"-category ^^' Would look pretty good if this was accomplished (except with more challenges and goals):

Thank you anyway!

[PyvesB]

Actually, things are easy enough to change! I tend to think of /aach generate as the starting point: all that it does is create JSON files on the server, but you can then simply edit them if you've got more specific needs. See #925 for an example of a user doing so. 😉

[TheLindblomer]

Oh, I feel a little dumb then. But if we changed the JSON files for the advancements, would they get reset if we would do /aach generate again? If they do I guess a work-around is to generate yourself in the files and never use /aach generate.

[PyvesB]

Oh, I feel a little dumb then.

No need to feel dumb - it's in no way obvious that Minecraft stores the advancements as JSON files on the server, I was myself quite surprised about that design initially! :)

Yes, they would reset if you re-run /aach-generate. This is why the user in #925 wrote a script to automatically perform the changes for them every time. Also keep in mind that there is one file per advancement, so it's easy enough to keep a copy of those that you don't want to change, run /aach-generate, and move the files back again.

[PyvesB]

Not much to add from my side right now, feel free to open new issues if you need more help in the future!