PyvesB / eclipse-solargraph

:gem: Ruby development tools for Eclipse.
https://marketplace.eclipse.org/content/ruby-solargraph
Eclipse Public License 2.0
30 stars 6 forks source link

Additional logging for launcher #25

Closed spchamp closed 2 years ago

spchamp commented 2 years ago

This patch would update the following plugin behaviors.

For processes initialized via BundleGemRunShortcut or LaunchConfigurationDelegate, a logging message will be created only on the following events:

Details from the changelog:

ConfigHelper

LaunchHelper

ReadaptDebugDelegate

BundleGemRunShortcut

RubyRunDelegate

LogHelper

This also removes the quote marks for argv0 in the readapt launcher

spchamp commented 2 years ago

Reviewing the patch, private static String LOGNAME should probably be declared as private static final String.

I'll add an update to the patch branch

PyvesB commented 2 years ago

Hello @spchamp 👋🏻 Thanks for all the PRs! Will aim at reviewing them over the weekend :)

spchamp commented 2 years ago

Candidly, thanks for the QA on the pull request. I've updated the branch