search

Q-Mobile / QGrid

🎛 QGrid: The missing SwiftUI collection view.
MIT License
1.64k stars 104 forks source link

Added property isScrollable to allow QGrid to work in parent ScrollViews #25

Closed kenmueller closed 4 years ago

kenmueller commented 4 years ago

I've added an isScrollable property since I'm using a QGrid in an app I'm working on, but it won't work in a parent ScrollView.

karolkulesza commented 4 years ago

Thanks for contributing.

Could you please remove *.xcuserdatad files from this PR? I believe they shouldn't be part of the commits.

Also, I can see you've modified some default existing values for the QGrid initializer. Please revert that, if possible.

kenmueller commented 4 years ago

Sure, working on it now. The initial values tripped me up a ton in the beginning because I feel like it's very odd to have a default value that is not 0 for the padding.

bryanbartow commented 4 years ago

@kenmueller Any update on this? I'm happy to make my own PR if you're too busy.

bryanbartow commented 4 years ago

@karolkulesza I opened my own PR in case @kenmueller is unable to get to this soon. #28

karolkulesza commented 4 years ago

Closing, as @bryanbartow's PR with this change has been just merged.