Q-Sharp / BattleBot

The Battle Legion discord bot!
MIT License
5 stars 1 forks source link

Subscription ping issues #37

Closed Greenfoot5 closed 4 years ago

Greenfoot5 commented 4 years ago

Describe the bug While a pull request was opened, and the bot should ping everyone/here when it has permission, it doesn't.

To Reproduce Steps to reproduce the behavior:

  1. Subscribe to a channel
  2. Send a message in the subscribed channel (not the subscriber)
  3. It won't ping everyone/here. Unsure on user pings.

Expected behavior It should be pinging

Screenshots If applicable, add screenshots to help explain your problem.

What platform are you using discord on? Desktop and android. Both Canary but should be unaffected by this.

Additional context Could be that only channel perms are checked, not server perms. The @everyone mention was also updated recently to also allow role pings.

Greenfoot5 commented 4 years ago

It doesn't make any checks for permissions. It seems this has not been added at all.

This was never mentioned in the update notes. I will re-label this to enhancement.