Closed jesswahlers closed 5 years ago
Fix with pull #41. Cheers!
Hi Jess,
I saw that you got an answer from Eric, but in addition to that, I think you’re trying to use the force field improperly. In a phosphoramidate, ONLY the P will coordinate to Pd, the N cannot bind at the same time. The pattern should only match if you’ve drawn a bond to the nitrogen also. Please don’t.
BTW, I still need to go through all the material you sent, it’s been a bit hectic here the last couple of weeks…
/Per-Ola
From: jesswahlers [mailto:notifications@github.com] Sent: den 26 september 2017 22:38 To: Q2MM/q2mm q2mm@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [Q2MM/q2mm] Merging structures with different bonds (#40)
An issue has arose with trying to merge a new ligand onto the template I have for the palladium allyl TSFF. The pattern that I am currently using is N0.Pd.P3, but the problem arises that the nitrogen and phosphorus are bonded in the new ligand. The template does not have these atoms bonded together. The new ligand is a phosphoramidite ligand while the typical ligand used is a PHOX ligand. This leads to me getting the error 'NoneType' object has no attribute 'property'. Is there a way to have different bonding parameters in the pattern between the ligand and the template.
In merge_structures_from_matchign_atoms() function the coding logic tries to determine if a bond is present in structure1 just like the bond in structure2. If it does then it simply tries to copy parameters, if it doesn't then it adds in a new bond. This is determined by comparing if the atom2 in the bond object is in the list of common atoms. In this case, the N0 and P3 atoms are in the list of common atoms but there is still no bond between them in the template so no new bond is created.
Using merge.py -g template_2.mae -g phosphoramidite.mae
atom.typ.txt.txthttps://github.com/Q2MM/q2mm/files/1334889/atom.typ.txt.txt mm3.fld.txthttps://github.com/Q2MM/q2mm/files/1334891/mm3.fld.txt template_2.mae.txthttps://github.com/Q2MM/q2mm/files/1334901/template_2.mae.txt phosphoramidite.mae.txthttps://github.com/Q2MM/q2mm/files/1334904/phosphoramidite.mae.txt
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Q2MM/q2mm/issues/40, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANVSND9MGRsjGiAU96-dt8INLuHAmSBxks5smWC6gaJpZM4Pk2TB.
Confidentiality Notice: This message is private and may contain confidential and proprietary information. If you have received this message in error, please notify us and remove it from your system and note that you must not copy, distribute or take any action in reliance on it. Any unauthorized use or disclosure of the contents of this message is not permitted and may be unlawful.
Yeah I figured those ligands wouldn't work since the transition state was different. I just won't use them. Thanks
Can someone sign off that this was fixed with PR #41 and close this issue? @jesswahlers
An issue has arose with trying to merge a new ligand onto the template I have for the palladium allyl TSFF. The pattern that I am currently using is N0.Pd.P3, but the problem arises that the nitrogen and phosphorus are bonded in the new ligand. The template does not have these atoms bonded together. The new ligand is a phosphoramidite ligand while the typical ligand used is a PHOX ligand. This leads to me getting the error 'NoneType' object has no attribute 'property'. Is there a way to have different bonding parameters in the pattern between the ligand and the template.
In merge_structures_from_matchign_atoms() function the coding logic tries to determine if a bond is present in structure1 just like the bond in structure2. If it does then it simply tries to copy parameters, if it doesn't then it adds in a new bond. This is determined by comparing if the atom2 in the bond object is in the list of common atoms. In this case, the N0 and P3 atoms are in the list of common atoms but there is still no bond between them in the template so no new bond is created.
Using merge.py -g template_2.mae -g phosphoramidite.mae
atom.typ.txt.txt mm3.fld.txt template_2.mae.txt phosphoramidite.mae.txt