Resolve multilingualism

Q42 / CT-3000

A tool for teaching Computational Thinking to kids

https://ct-3000.firebaseapp.com/

MIT License

10 stars 3 forks source link

Resolve multilingualism #24

Closed Primigenus closed 7 years ago

Primigenus commented 8 years ago

The readme and repo are in English but the tool and examples are in Dutch. That limits the appeal of the codebase. What would the impact be of offering an English translation?

guidobouman commented 8 years ago

Not that big actually. The whole editor language is generated based on a json file, so we could dynamically swap that out.

As far as the rest: in the source code, the objects are dutch. So that's a bit awkward if we would like to welcome PR's from international developers.

guidobouman commented 8 years ago

Language config: https://github.com/Q42/CT-3000/blob/master/src/config/language.json

Objects: https://github.com/Q42/CT-3000/tree/master/src/components/editor/objects

lukasvan3l commented 8 years ago

definitely, would like a language switch! But that's pretty nasty because to translate you'd need to take apart filenames (weer-goed.png) and variable names (weather = good). But yeah, definitely want this!

fknipp commented 8 years ago

@guidobouman The parser component also contains Dutch strings:

https://github.com/Q42/CT-3000/blob/master/src/classes/parser.js

guidobouman commented 8 years ago

Ah, true! That should be part of the language config, if you ask me.

lukasvan3l commented 8 years ago

Working on it in this branch: https://github.com/Q42/CT-3000/tree/feature/translations

It works for NL and EN, just change the language in /config/config.js. It uses a reflux store where it maps words in the chosen language document to the original dutch ones, based on the order of the items in the /config/language-*.json files.

Still some work to do:

[x] Add chapter in README that tells how to translate
[x] Have language setting get read from URL
[x] Make language toggle in the UI

fknipp commented 8 years ago

While doing translations for German in this branch, I've found the following issues regarding the digiboard:

The digiboard works only for NL (almost) completely.
In EN: The name cannot be set, messages cannot be sent.
In DE: There's no connection to the digibord at all, the digiboard shows always 0 gebruiker.
In all languages: Regardless of the selected music, the digiboard always shows Geen muziek geselecteerd, when I switch on the music as user.

lukasvan3l commented 7 years ago

Cool, just finished my own TODO's, and worked to translate the digiboard part of the app.

@fknipp could you add the DE translations for the digiboard? They're marked TODO in https://github.com/Q42/CT-3000/blob/feature/translations/src/config/language-de.json

I haven't looked at the functionality of the digiboard in different languages, will get to that next, but that should be the last part of this feature :)

fknipp commented 7 years ago

Cool, I've just set the German translations.

guidobouman commented 7 years ago

Nice work gentlemen!