Circle markup needs to call markup.save()

Q726kbXuN / nytxw_puz

Turn NY Times crosswords into Across Lite files

The Unlicense

41 stars 10 forks source link

Circle markup needs to call markup.save() #16

Closed tkoft closed 2 years ago

tkoft commented 2 years ago

https://github.com/Q726kbXuN/nytxw_puz/blob/master/nyt.py#L308

Puzzles with circle markups don't get output properly, markup.save() needs to get called to save the markups to the puz extension. E.g. The 2020-10-12 puzzle

Q726kbXuN commented 2 years ago

@tkoft

Can you provide more details? Right now if I convert 2020-10-12 and open the resulting puzzle in Across Lite, I see:

This is because save is called during the tobytes operation.

This did reveal an unrelated bug with the notes not handling a None case that I'll be fixing.

Q726kbXuN commented 2 years ago

5fb7e592072695bb0e6cc60b3d490a30ba5f5186 fixes the issue with the notes.