search

QAAFI / REMS2020

REMS Database
0 stars 1 forks source link

How many different crop soil templates are needed? #222

Open MikeStower opened 3 years ago

MikeStower commented 3 years ago

To get the output runnable in #208, there needed to be two template files for soil, because Sorghum had different requirements to Wheat (e.g. SoilNitrogen model instead of Nutrients). Will there need to be other soil templates for other crops, or is Sorghum the only outlier we want to handle?

jbrider commented 3 years ago

I haven't checked yet, but I think the recommendation is to move across to Nutrients. I'm assuming you have created one for SoilNitrogen - probably be worth creating one for Nutrients as well - maybe you can explain the differences to me.

On Thu, Aug 12, 2021 at 12:13 PM Mike Stower @.***> wrote:

To get the output runnable in #208 https://github.com/QAAFI/REMS2020/issues/208, there needed to be two template files for soil, because Sorghum had different requirements to Wheat (e.g. SoilNitrogen model instead of Nutrients). Will there need to be other soil templates for other crops, or is Sorghum the only outlier we want to handle?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/QAAFI/REMS2020/issues/222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE3G7AGHVN7STX226NV3WLT4MU25ANCNFSM5B764PVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

MikeStower commented 3 years ago

I haven't looked into the Apsim code that deeply, but from what I can tell it uses the name of the SoilCrop model to determine the type of crop and look for the required models accordingly. So if there is a SoilCrop called 'SorghumSoil' it looks for a SoilNitrogen model and throws an error if one isn't found. If that same SoilCrop was named 'WheatSoil' it would look for a Nutrient model instead. So we have to check the name of the crop and output the appropriate model to have the simulation be runnable.