search

QAZIMAAZARSHAD / Apni-Dukaan

An E-commerce site to buy products of need.
https://qazimaazarshad.github.io/Apni-Dukaan/
MIT License
59 stars 104 forks source link

Create a "Baby & Kids" page #10

Closed QAZIMAAZARSHAD closed 3 years ago

Baba-Yaga-1 commented 3 years ago

I am a participant of DevIncept. Can I work on this issue ?

QAZIMAAZARSHAD commented 3 years ago

I will assign you this issue when DCP will start from 10th July.

Baba-Yaga-1 commented 3 years ago

Do I have to follow a certain theme for this page ?

QAZIMAAZARSHAD commented 3 years ago

Just follow the color theme.

And implement any idea for styling, but the footer and header should be the same. We will adopt the best theme for all the pages later when other pages are also created.

Baba-Yaga-1 commented 3 years ago

Should I make a static page for now ?

QAZIMAAZARSHAD commented 3 years ago

Should I make a static page for now ?

Yess, refer to some websites and adopt their design if you want.

Baba-Yaga-1 commented 3 years ago

Okay, sure.

QAZIMAAZARSHAD commented 3 years ago

Share website link.

Also add some details like color, brand, price. Also, add footer and header.

Baba-Yaga-1 commented 3 years ago

Okay, sure. I will make the changes and share the link.

I haven't changed the header and footer.

Baba-Yaga-1 commented 3 years ago

Can you check this ? I have made the changes and I haven't changed the header and footer.

QAZIMAAZARSHAD commented 3 years ago

The slider image is very large.

Arrange cards properly, left and right margins should be equal.

Fetch upstream also your repo is not updated.

Align nav bar properly.

Baba-Yaga-1 commented 3 years ago

Can you check it ? I have made the changes.

QAZIMAAZARSHAD commented 3 years ago

No still not correct.

First, fetch upstream keep your repo updated.

Reduce the height and increase the width to 100% of the slideshow. Also, replace slideshow images, use modelling kids. Add three cards in one row.

Baba-Yaga-1 commented 3 years ago

I did update the repo. So I need to replace the slideshows with cards or I just need to chnge the pictures ? Also does this page have to show the links to other pages like clothes, furniture etc or only the navbar is enough ?

QAZIMAAZARSHAD commented 3 years ago

Just adjust the size of the slideshow. Change images in the slideshow. By cards, I meant products like jackets, shoes, etc. there are two cards in each row and plenty of margin on the right side. Decrease the size of these cards and add 3 in each row. And yes, the header and the footer should be the same as other pages and each page should be linked to each other.

Baba-Yaga-1 commented 3 years ago

I am facing an error while using "git pull origin master" command. I haven't pushed any of the files yet. Can you look into it?

git

Also, I made the changes. I set the margin and padding properly.

I also changed the pictures in carousel. I have also updated the header and footer. Can you check ?

QAZIMAAZARSHAD commented 3 years ago

Your changes are not reflected in the link.

QAZIMAAZARSHAD commented 3 years ago

image image image

QAZIMAAZARSHAD commented 3 years ago

@satyampgt4 please help @Baba-Yaga-1 in resolving issues.

QAZIMAAZARSHAD commented 3 years ago

@satyampgt4 look into this.

satyampgt4 commented 3 years ago

I am facing an error while using "git pull origin master" command. I haven't pushed any of the files yet. Can you look into it?

git

is this issue solved or not... ?

if not then please commit you changes before pulling from upstream one more thing please pull from upstream not from origin

Baba-Yaga-1 commented 3 years ago

I tried that and now its showing another error.

commit

Also what should I do about the problem that is occurring while clicking the link ? As the changes are shown while I view the link.

satyampgt4 commented 3 years ago

I tried that and now its showing another error.

commit

Also what should I do about the problem that is occurring while clicking the link ? As the changes are shown while I view the link.

it is showing you have merge conflict if you are using vs code you can easily see the current and incoming update you have to resolve them and after all the conflict get resolved then commit it

if find any difficulty in it ping me on slack !

Baba-Yaga-1 commented 3 years ago

Hey thanks, that issue got solved.

Also what should I do about the problem that is occurring while clicking the link ? As the changes are shown while I view the link.

But what about this ? Can you open the link and check, whether the margin and padding has been set properly or not ?

QAZIMAAZARSHAD commented 3 years ago

No nothing has been updated.

Everything's wrong same as before.

satyampgt4 commented 3 years ago

Hey thanks, that issue got solved.

Also what should I do about the problem that is occurring while clicking the link ? As the changes are shown while I view the link.

But what about this ? Can you open the link and check, whether the margin and padding has been set properly or not ?

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

try to use flex may be it will help you

satyampgt4 commented 3 years ago

or use 13px in margin left and right instead of 20px

QAZIMAAZARSHAD commented 3 years ago

Cards are now 3 in each row. But still, not properly in the center, correct the margin.

But the navbar, footer, is still wrong. And remove that slideshow of the home page.

Baba-Yaga-1 commented 3 years ago

Cards are now 3 in each row. But still, not properly in the center, correct the margin.

But the navbar, footer, is still wrong. And remove that slideshow of the home page.

You mean the slider for the advertisement?

QAZIMAAZARSHAD commented 3 years ago

Yes no need for that slider, baby slider is enough.

Baba-Yaga-1 commented 3 years ago

Okay I will update it.

So the navbar and footer of this page should match with the index page ?

index

QAZIMAAZARSHAD commented 3 years ago

Yes

Baba-Yaga-1 commented 3 years ago

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

I will add the logo too, but for now can you check header, footer, margins ?

QAZIMAAZARSHAD commented 3 years ago

Footer has been updated check.

The right margin is still a bit more.

And compress the height of the slider a bit. Also update the images use images which also have like sale, 40% of on boys clothes, etc.

Baba-Yaga-1 commented 3 years ago

Footer has been updated check.

The right margin is still a bit more.

And compress the height of the slider a bit. Also update the images use images which also have like sale, 40% of on boys clothes, etc.

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

QAZIMAAZARSHAD commented 3 years ago

Footer is not correct.

It should be similar to the footer as in the home page.

Baba-Yaga-1 commented 3 years ago

Footer is not correct.

It should be similar to the footer as in the home page.

I have updated the repo. https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

QAZIMAAZARSHAD commented 3 years ago

image

image

Compare.

Correct it.

Baba-Yaga-1 commented 3 years ago

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

I updated it.

QAZIMAAZARSHAD commented 3 years ago

Nope.

Not reflected in the link you shared. image

Baba-Yaga-1 commented 3 years ago

Can you check it?

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

QAZIMAAZARSHAD commented 3 years ago

No not correct.

Why are you struggling too much in this part, just copy the code from other pages.

QAZIMAAZARSHAD commented 3 years ago

Your navbar is also wrong.

Correct that as well.

Baba-Yaga-1 commented 3 years ago

I did, why wouldn't I copy the codes. Let me show you the proof. This is the home page that i am able to view after opening it from my local repo.

homepage

This is the babyandkids page,

babyAndkidspage

These are the codes, cssoffooter footer

QAZIMAAZARSHAD commented 3 years ago

image image

This is the screenshot of when I open your link.

QAZIMAAZARSHAD commented 3 years ago

Something must be wrong.

QAZIMAAZARSHAD commented 3 years ago

Create a PR then we will figure out what's wrong.

Baba-Yaga-1 commented 3 years ago

I made the PR, you can check it.