search

QAZIMAAZARSHAD / Voters-Registration-Portal

An online form for the registration of voters in the electoral roll.
https://qazimaazarshad.github.io/Voters-Registration-Portal/
MIT License
49 stars 132 forks source link

Responsiveness feature checked of submitted file | Image fixed | Line edited #360

Closed shreya-madhwal closed 3 years ago

shreya-madhwal commented 3 years ago

Fixes #320 Issue-Fix the image in submitted.html also check the responsiveness of page

The changes I've made:

  1. Image got fixed.
  2. Added few lines of code for responsiveness of the page in submitted.html and submitted.css
  3. Edited the line as mentioned in the issue.

Any unusual behaviour in the code: NA

Additional context : image

Done under lgmsoc'21

QAZIMAAZARSHAD commented 3 years ago

Share the website link so I can review your changes.

shreya-madhwal commented 3 years ago

https://github.com/shreya-madhwal/Voters-Registration-Portal/blob/master/submitted.html

This is the link sir.

QAZIMAAZARSHAD commented 3 years ago

No this not a website link.

Host your website somewhere like GitHub pages or repl.it then share.

QAZIMAAZARSHAD commented 3 years ago

https://github.com/shreya-madhwal/Voters-Registration-Portal/blob/master/submitted.html

This is the link sir.

Like this https://qazimaazarshad.github.io/Voters-Registration-Portal/

shreya-madhwal commented 3 years ago

https://github.com/shreya-madhwal/Voters-Registration-Portal/blob/master/submitted.html This is the link sir.

Like this https://qazimaazarshad.github.io/Voters-Registration-Portal/

okk sir got it wait lemme send it.

shreya-madhwal commented 3 years ago

https://shreya-madhwal.github.io/Voters-Registration-Portal/

QAZIMAAZARSHAD commented 3 years ago

@shreya-madhwal you have mentioned the wrong issue number.

This is issue #320.

QAZIMAAZARSHAD commented 3 years ago

Also, your repo is not updated.

Always fetch upstream before working on any issue, PR is merged only because the submitted page was even with your repo otherwise it would have shown conflicts.

shreya-madhwal commented 3 years ago

Ok got it. But there's one doubt when u assigned me this issue it was having level1 tag but now here it is showing level0 could u pls help me in this.

QAZIMAAZARSHAD commented 3 years ago

Ok got it. But there's one doubt when u assigned me this issue it was having level1 tag but now here it is showing level0 could u pls help me in this.

Oo this is a mistake. I was adding label 1 but somehow I clicked level 0 I think.

shreya-madhwal commented 3 years ago

Ok got it. But there's one doubt when u assigned me this issue it was having level1 tag but now here it is showing level0 could u pls help me in this.

Oo this is a mistake. I was adding label 1 but somehow I clicked level 0 I think.

Thanks @QAZIMAAZARSHAD for your help and support.