QAZIMAAZARSHAD / Voters-Registration-Portal

An online form for the registration of voters in the electoral roll.
https://qazimaazarshad.github.io/Voters-Registration-Portal/
MIT License
49 stars 132 forks source link

Shifting the dark/light toggle button in mobile view #406

Closed anushruti11 closed 3 years ago

anushruti11 commented 3 years ago

Fixes #403

Describe the changes you've made

Shifted the dark/light toggle button in footer in mobile view

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Deploy your changes to github page or netlify and mention deployment link:

https://anushruti11.github.io/Voters-Registration-Portal/

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow. How someone can test your code?

Checklist

QAZIMAAZARSHAD commented 3 years ago

@anushruti11 you have to do this on every single page.

But you have disturbed the desktop view. Do not change anything in desktop view.

And the changed mobile view is also very bad. Shift the toggle at the top in the footer parallel to the Contact us heading or choose a position where it looks best and other contents are not displaced.

QAZIMAAZARSHAD commented 3 years ago

Retry.

anushruti11 commented 3 years ago

@anushruti11 you have to do this on every single page.

But you have disturbed the desktop view. Do not change anything in desktop view.

And the changed mobile view is also very bad. Shift the toggle at the top in the footer parallel to the Contact us heading or choose a position where it looks best and other contents are not displaced.

Okay I will give it a try.