QAZIMAAZARSHAD / Voters-Registration-Portal

An online form for the registration of voters in the electoral roll.
https://qazimaazarshad.github.io/Voters-Registration-Portal/
MIT License
49 stars 132 forks source link

Relevant message #412

Closed yuhang0627 closed 3 years ago

yuhang0627 commented 3 years ago

Fixes #282

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know! I had change all the show password button to the bi eye logo make it looking more nice.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Deploy your changes to github page or netlify and mention deployment link:

Add the deployment link here.

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow. How someone can test your code?

Checklist

QAZIMAAZARSHAD commented 3 years ago

@yuhang0627 you have compressed the size of the input field.

It should be of the same size like other fields as it was before.

Also, try to shift the Eye icon inside the input tab.

QAZIMAAZARSHAD commented 3 years ago

And fetch upstream also your repo is 14 commits behind.

yuhang0627 commented 3 years ago

Like these okay?

forgetPass login signup

QAZIMAAZARSHAD commented 3 years ago

Yes looks better.

But I think you have also modified the buttons.

Don't change anything else.

QAZIMAAZARSHAD commented 3 years ago

Reset the buttons.

Fetch upstream.

And when you are done share a deployment link so I can review your changes.

yuhang0627 commented 3 years ago

Reset the buttons.

Fetch upstream.

And when you are done share a deployment link so I can review your changes.

I had reset and fetch upstream. How I share a deployment link? Newbie here sorry.

QAZIMAAZARSHAD commented 3 years ago

Host your website on GitHub Pages, Netlify, repl.it or any other platform then share the link.

yuhang0627 commented 3 years ago

Host your website on GitHub Pages, Netlify, repl.it or any other platform then share the link.

This? https://yuhang0627.github.io/Voters-Registration-Portal/

QAZIMAAZARSHAD commented 3 years ago

Host your website on GitHub Pages, Netlify, repl.it or any other platform then share the link.

This? https://yuhang0627.github.io/Voters-Registration-Portal/

Yes.

QAZIMAAZARSHAD commented 3 years ago

@yuhang0627 the confirm password icon is not working in forget pass and signup page.

And why you closed PR?

Make another one.