Shifting the dark/light toggle button in mobile view

anushruti11 commented 3 years ago

Fixes #403

Describe the changes you've made

Shifted the dark/light toggle button in footer in mobile view

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

NA

Deploy your changes to github page or netlify and mention deployment link:

https://anushruti11.github.io/Voters-Registration-Portal/index.html

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow. How someone can test your code?

Checklist

[x] I have mentioned related issue number in PR description.
[ ] I have added screenshots and related demo links of my changes..
[x] The title of my pull request is a short description of the requested changes.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@nlok5923 check this out.

nlok5923 commented 3 years ago

@anushruti11 thanks for opening this pr i am investigating on this issue in the mean time you can opt some other issues to work upon.

anushruti11 commented 3 years ago

@QAZIMAAZARSHAD I have made all the changes please review it now.

QAZIMAAZARSHAD commented 3 years ago

Check login page.

anushruti11 commented 3 years ago

Check login page.

QAZIMAAZARSHAD commented 3 years ago

Compare with other pages.

anushruti11 commented 3 years ago

Compare with other pages.

Both login and sign up page have common CSS file. I haven't applied anything different for login page.

QAZIMAAZARSHAD commented 3 years ago

Something must be wrong. In desktop view also login page has a slightly different position of the toggle button.

Review code again.

anushruti11 commented 3 years ago

Something must be wrong. In desktop view also login page has a slightly different position of the toggle button.

Review code again.

Added separate styling for login page in the login.html file

nlok5923 commented 3 years ago

code and UI both looks good to me just remove the scroll effect.

anushruti11 commented 3 years ago

code and UI both looks good to me just remove the scroll effect.

I haven't added the scroll effect it was there in the original website. How it can be removed?

nlok5923 commented 3 years ago

code and UI both looks good to me just remove the scroll effect.

I haven't added the scroll effect it was there in the original website. How it can be removed?

Yeah I am aware of that but it's fine if you're not willing to do it in this pr will create another issue for the same @QAZIMAAZARSHAD the changes looks good to me just after resolving recent requested changes I think we can merge the pr.

anushruti11 commented 3 years ago

code and UI both looks good to me just remove the scroll effect.

I haven't added the scroll effect it was there in the original website. How it can be removed?

Yeah I am aware of that but it's fine if you're not willing to do it in this pr will create another issue for the same @QAZIMAAZARSHAD the changes looks good to me just after resolving recent requested changes I think we can merge the pr.

@nlok5923 Thanks for guiding me..

QAZIMAAZARSHAD / Voters-Registration-Portal