search

QAZIMAAZARSHAD / Voters-Registration-Portal

An online form for the registration of voters in the electoral roll.
https://qazimaazarshad.github.io/Voters-Registration-Portal/
MIT License
50 stars 132 forks source link

form validation #420

Closed dilroseR closed 3 years ago

dilroseR commented 3 years ago

Fixes #30

Describe the changes you've made

created form validation on email, phone no and pincode

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

https://user-images.githubusercontent.com/70878223/126866843-a0226916-46a1-47a3-baad-847e6c725601.mp4

Checklist

QAZIMAAZARSHAD commented 3 years ago

There are few other fields also.

Share the website link so I can review your changes.

dilroseR commented 3 years ago

There are few other fields also.

Share the website link so I can review your changes.

but the page is running locally right? how to send the link?

dilroseR commented 3 years ago

There are few other fields also.

Share the website link so I can review your changes.

can you specify which ones so I'll work on it

QAZIMAAZARSHAD commented 3 years ago

Check everything from top to bottom.

State, district, name, document uploaded, if selected other in disability, radio buttons, etc.

Are all the mandatory fields really mandatory?

Is the form gets submitted without non-mandatory inputs?

Check everything. And specific sweet alert for all inputs.

dilroseR commented 3 years ago

Check everything from top to bottom.

State, district, name, document uploaded, if selected other in disability, radio buttons, etc.

Are all the mandatory fields really mandatory?

Is the form gets submitted without non-mandatory inputs?

Check everything. And specific sweet alert for all inputs.

ok , I'll check for all except non-mandatory

QAZIMAAZARSHAD commented 3 years ago

But if someone has filled non-mandatory fields, it should be proper.

dilroseR commented 3 years ago

But if someone has filled non-mandatory fields, it should be proper.

alright, i'll check those as well

nlok5923 commented 3 years ago

There are few other fields also. Share the website link so I can review your changes.

but the page is running locally right? how to send the link?

you need to deploy your forked repo to any static deployment services like netlify and gh pages after that only we can verify the changes done by you.

dilroseR commented 3 years ago

There are few other fields also. Share the website link so I can review your changes.

but the page is running locally right? how to send the link?

you need to deploy your forked repo to any static deployment services like netlify and gh pages after that only we can verify the changes done by you.

https://formvalidate12.netlify.app/ Can you check please what is the issue?

QAZIMAAZARSHAD commented 3 years ago

@dilroseR districts are not displaying in the drop-down list.

dilroseR commented 3 years ago

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

dilroseR commented 3 years ago

@dilroseR districts are not displaying in the drop-down list.

should i do that as well?

QAZIMAAZARSHAD commented 3 years ago

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

It was always present. Chek again, compare with main website. image

dilroseR commented 3 years ago

@dilroseR districts are not displaying in the drop-down list.

it wasn't there before also

It was always present. Chek again, compare with main website. image

alright, i'll have a look bdw did you check the specific alert and found out what's going wrong? if yes then please let me know

QAZIMAAZARSHAD commented 3 years ago

If we select option 3A in the declaration section still it prompts to select option 3a or 3b.

Email and mobile are not mandatory still it prompts to enter an email address.

The form gets accepted without: First-time voter or transfer radio button selection in the First section. Without any selections in the mandatory specifications section. Without any details other than pin in the address section. Without city name, location and I am aware agreement in the declaration section. And without Captcha.

dilroseR commented 3 years ago

If we select option 3A in the declaration section still it prompts to select option 3a or 3b.

Email and mobile are not mandatory still it prompts to enter an email address.

The form gets accepted without: First-time voter or transfer radio button selection in the First section. Without any selections in the mandatory specifications section. Without any details other than pin in the address section. Without city name, location and I am aware agreement in the declaration section. And without Captcha.

ok thanks i'll check

dilroseR commented 3 years ago

i've sent you a video. kindly check that on slack

QAZIMAAZARSHAD commented 3 years ago

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

dilroseR commented 3 years ago

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

QAZIMAAZARSHAD commented 3 years ago

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

No,

I mean the changes in this PR are not creating this problem, so check the problems in your recent updates in your local project. you will find what is creating the issue.

dilroseR commented 3 years ago

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

@dilroseR this problem is not occurring in the link you shared https://formvalidate12.netlify.app/ compare your new changes,

are you talking about fetch and merge?

No,

I mean the changes in this PR are not creating this problem, so check the problems in your recent updates in your local project. you will find what is creating the issue.

ill try creating a new deployment link with the new changes then pls check

dilroseR commented 3 years ago

https://blissful-roentgen-bf6449.netlify.app/ here is the new link

QAZIMAAZARSHAD commented 3 years ago

LGTM

No. The form is getting submitted/reset without accepting all the details and with wrong inputs. Not giving specific prompts for each wrong inputs.

@kanak22 help @dilroseR in resolving this issue.

kanak22 commented 3 years ago

LGTM

No. The form is getting submitted/reset without accepting all the details and with wrong inputs. Not giving specific prompts for each wrong inputs.

@kanak22 help @dilroseR in resolving this issue.

Wrong inputs and specific prompts is what I noticed but the issue was only about prompting for the mandatory fields that info isn't filled yet

QAZIMAAZARSHAD commented 3 years ago

Even that condition is not fulfilled, the form gets reset without all inputs.

And the issue is to completely validate every input field with proper input, error messages, etc.

dilroseR commented 3 years ago

the form gets resetted whenever an alert appears. kindly help me on how to tackle this