QAZIMAAZARSHAD / Voters-Registration-Portal

An online form for the registration of voters in the electoral roll.
https://qazimaazarshad.github.io/Voters-Registration-Portal/
MIT License
50 stars 132 forks source link

Changed footer size in mobile #422

Closed nik464 closed 3 years ago

nik464 commented 3 years ago

Fixes #(issue number)

404

Describe the changes you've made

I have changed size of the footer in mobile. As screen reduces size from 992 px, footer height becomes 40 px instead of 80 px.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

No there is no unusual behaviour

Deploy your changes to github page or netlify and mention deployment link:

Add the deployment link here.

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

You can check index. html and change the size of the page by inspect element.

Checklist

QAZIMAAZARSHAD commented 3 years ago

Host your website and share the website link so I can review your changes.

nik464 commented 3 years ago

https://hardcore-bell-2341cc.netlify.app/

For less then 992, that is small screen footer becomes half.

QAZIMAAZARSHAD commented 3 years ago

Fetch upstream your repo is 26 commits behind.

QAZIMAAZARSHAD commented 3 years ago

And nothing has changed. It is similar.

Check image

QAZIMAAZARSHAD commented 3 years ago

Size of footer is same.

QAZIMAAZARSHAD commented 3 years ago

After the changes check every single page.

Then only make PR.

nik464 commented 3 years ago

ok is it not working for index.html? I will surely make changes in all pages . Actually i thought only black footer in index.html has to be made small.

QAZIMAAZARSHAD commented 3 years ago

No need to change the footer of the index page. That's perfectly fine.

The problem is with other pages.