search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
38 stars 15 forks source link

Update plot_lassoCV.py #109

Closed josephsalmon closed 3 years ago

josephsalmon commented 3 years ago

Useless line in plot_lassoCV.py leading to possible confusion.

mathurinm commented 3 years ago

Those are Lassos are not the same, one is the sparse-ho model (inner problem) and the other is the scikit-learn model

josephsalmon commented 3 years ago

I got confused by the naming... my bad. but still I think a useless line was around.

codecov-io commented 3 years ago

Codecov Report

Merging #109 (66149cd) into master (d3a1245) will increase coverage by 1.48%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   76.59%   78.07%   +1.48%     
==========================================
  Files          40       41       +1     
  Lines        2931     3070     +139     
  Branches      297      336      +39     
==========================================
+ Hits         2245     2397     +152     
+ Misses        605      577      -28     
- Partials       81       96      +15
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sparse_ho/ho.py 50.00% <0.00%> (ø)
sparse_ho/algo/forward.py 66.66% <0.00%> (ø)
sparse_ho/algo/backward.py 27.27% <0.00%> (ø)
sparse_ho/algo/implicit_forward.py 89.58% <0.00%> (ø)
sparse_ho/tests/test_docstring_parameters.py 72.66% <0.00%> (ø)
sparse_ho/utils_plot.py 67.10% <0.00%> (+67.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3a1245...66149cd. Read the comment docs.