QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
40 stars 15 forks source link

[MRG] ENH: Start testing criterion, datasets, optimizer #113

Closed mathurinm closed 3 years ago

mathurinm commented 3 years ago

Still somes fixes to do, feel free to push to the branch @QB3

codecov-io commented 3 years ago

Codecov Report

Merging #113 (316ee93) into master (4390f63) will not change coverage. The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   78.91%   78.91%           
=======================================
  Files          41       41           
  Lines        3030     3030           
  Branches      326      326           
=======================================
  Hits         2391     2391           
  Misses        546      546           
  Partials       93       93           
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sparse_ho/algo/forward.py 66.66% <ø> (ø)
sparse_ho/criterion/multiclass_logreg.py 67.64% <ø> (ø)
sparse_ho/models/enet.py 88.94% <ø> (ø)
sparse_ho/models/lasso.py 85.07% <ø> (ø)
sparse_ho/models/logreg.py 86.53% <ø> (ø)
sparse_ho/models/svm.py 69.77% <ø> (ø)
sparse_ho/models/svr.py 80.16% <ø> (ø)
sparse_ho/models/wlasso.py 85.79% <ø> (ø)
sparse_ho/optimizers/adam.py 18.18% <ø> (ø)
sparse_ho/optimizers/line_search.py 56.16% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4390f63...316ee93. Read the comment docs.

QB3 commented 3 years ago

can you put a TODO so that it does not get lost ?

A todo on what?

QB3 commented 3 years ago

please fix everywhere

please check the entire diff

done