search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
38 stars 15 forks source link

ENH: write common base class for sparse primal models #115

Open mathurinm opened 3 years ago

mathurinm commented 3 years ago

After writing #111 this I think Lasso, ElasticNet, WeightedLasso and Logistic regression could inherit from a common class.

This would avoid a bit of duplication eg the following methods: get_beta, sign, reduce_X, reduce_y

Not sure if it's worth it, happy to discuss