search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
38 stars 15 forks source link

bug sure #130

Closed mathurinm closed 2 years ago

mathurinm commented 2 years ago

[previous PR was starting from the wrong branch] I don't know why but the script I pushed fails. @Klopfe it seems related to warm_start that you fixed in SVR, can you have a look ?

codecov-commenter commented 2 years ago

Codecov Report

Merging #130 (5e495b2) into master (72f203f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          42       42           
  Lines        3347     3347           
  Branches      353      353           
=======================================
  Hits         2738     2738           
  Misses        511      511           
  Partials       98       98
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72f203f...5e495b2. Read the comment docs.

mathurinm commented 2 years ago

The culprit is ImplicitForward(criterion) that is a leftover from a long time ago, now ImplicitForward does not take criterion as an argument