search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
38 stars 15 forks source link

Fix doc #134

Closed QB3 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #134 (c4a232e) into master (eaad89f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          42       42           
  Lines        3347     3347           
  Branches      377      377           
=======================================
  Hits         2738     2738           
  Misses        511      511           
  Partials       98       98
Flag Coverage Δ
unittests ∅ <0.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaad89f...c4a232e. Read the comment docs.

QB3 commented 2 years ago

I do not understand why the test are passing on the PRs but not on master: https://app.circleci.com/pipelines/github/QB3/sparse-ho/989/workflows/98321417-50f2-4d6b-8d0c-b96b60d6dc43/jobs/995

mathurinm commented 2 years ago

It is because in the instructions of the command that fails, you have: if [[ ${CIRCLE_BRANCH} == "master" ]]; then that is ran only on master.

mathurinm commented 2 years ago

It is fixed on master: https://circleci.com/gh/QB3/sparse-ho/998?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link