Structure of the files

[Klopfe]

The file models.py is getting big and I think we could create directories (models, criterion and algo) and split within each directory the files criterion and models into individual files for each model and criterion.

What do you think about that? Do you have suggestions?

[mathurinm]

I was thinking the opposite, merging the algo files. I prefer not to have 12 files open in my editor, when we do global renaming of a variable etc My 2 cents

[Klopfe]

It's also a possibilility

[QB3]

I do not know what is the canonical way of doing it, but I would also tend to vote for splitting files. I addition of being conceptually clearer, I find the models.py file is becoming too large: https://github.com/QB3/sparse-ho/blob/master/sparse_ho/models.py#L1778

[agramfort]

I would split in

models/ base.py # containing BaseModel class lasso.py # importing from base the BaseModel to inherit logreg.py ...

[Klopfe]

Just to be sure, the methods of Lasso, SVM, etc... have the same name but are specific to each of the models, in that case do you implement an empty function in the parent class BaseModel with the same name? Or would we only put an init function and maybe some methods that are shared by all models without being specific ?

[agramfort]

any method that must be implemented by all inherited classes should be listed as I did in the abstract base class. From now on you know better then me what these methods should be.

the contract is that if a subclass implement these methods it will work

[Klopfe]

ok thanks