search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
39 stars 15 forks source link

ENH changed color map + rm algo param from grid search #87

Closed QB3 closed 3 years ago

QB3 commented 3 years ago

x weird cmap pb in enet

mathurinm commented 3 years ago

while there's a PR, in grid_search there's an algo instanciated which can be removed

QB3 commented 3 years ago

However it seems that the transparency has been broken: https://658-252772479-gh.circle-artifacts.com/0/dev/auto_examples/plot_held_out_enet.html#sphx-glr-auto-examples-plot-held-out-enet-py

QB3 commented 3 years ago

while there's a PR, in grid_search there's an algo instanciated which can be removed

Do you want to instantiate it inside? in an hidden way?

mathurinm commented 3 years ago

Hm I thought that it was harmless to delete algo, but missed that grid_search needed it. Why ? It's not used inside the grid_search function

QB3 commented 3 years ago

Hm I thought that it was harmless to delete algo, but missed that grid_search needed it. Why ? It's not used inside the grid_search function

Humm, it seems that it is simpler that what I thought indeed. I will remove this algo

QB3 commented 3 years ago

good for you @agramfort ?

agramfort commented 3 years ago

thx @QB3 and @mathurinm