search

QB3 / sparse-ho

Fast hyperparameter settings for non-smooth estimators:
http://qb3.github.io/sparse-ho
BSD 3-Clause "New" or "Revised" License
38 stars 15 forks source link

factorize some code to remove code dupe #92

Closed agramfort closed 3 years ago

agramfort commented 3 years ago

@Klopfe see this as inspiration and have a look at my XXX comments.

please take over by pushing directly on this PR.

Klopfe commented 3 years ago

Thanks a lot @agramfort ! I will take over and push directly on this PR.

agramfort commented 3 years ago

@Klopfe diff looks good but i don't know why CIs fail.

can you have a look? THen +1 for MRG when CIs are green.

Klopfe commented 3 years ago

Yes I will have a look, i don't know why either, the tests are ok on local and no flake8 but I will try and fix that

agramfort commented 3 years ago

Thanks @Klopfe