QC-UCI / qc-uci.club

also available at qc-uci.github.io
https://www.qc-uci.club
2 stars 3 forks source link

Create fixed size of images in slideshow #93

Closed dssikdar closed 1 year ago

dssikdar commented 1 year ago

It would be nice to have a fixed size of images (certain height by certain width) so that the "About Us" section does not change position as the slideshow plays through.

omarcostahamido commented 1 year ago

Agreed. If you want I can try that with code, not image editing. 2 options: a) make it scale in terms of height, meaning some images will be larger others will not use full width. b) making sure images always use all the available area, and visually cropping them in height. What do you think?

On Sat, Aug 5, 2023, 9:02 AM Diptanshu Sikdar @.***> wrote:

It would be nice to have a fixed size of images (certain height by certain width) so that the "About Us" section does not change position as the slideshow plays through.

— Reply to this email directly, view it on GitHub https://github.com/QC-UCI/qc-uci.club/issues/93, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL4NAB4PSG7HJIZL43I6N3XTX4ZJANCNFSM6AAAAAA3FBZFNU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dssikdar commented 1 year ago

Yes, I would prefer if we didn't edit the images.

Could you explain option (b) a bit more - as in how it will look?

omarcostahamido commented 1 year ago

Option b is basically how it works right now, as in images are scaled based on width, but their height will be cropped to in order to keep the div height constant

dssikdar commented 1 year ago

Oh okay. Since I don't want to crop the images based on height, let's go with option a.

omarcostahamido commented 1 year ago

DONE