While a new flavor release is building, the NaaVRE base image list is empty - Githubissues

QCDIS / NaaVRE

BSD 3-Clause "New" or "Revised" License

3 stars 2 forks source link

While a new flavor release is building, the NaaVRE base image list is empty #1418

Closed gpelouze closed 2 months ago

gpelouze commented 2 months ago

When $BASE_IMAGE_TAGS_URL is not defined, we fall back to https://github.com/QCDIS/NaaVRE-flavors/releases/latest/download/base_image_tags.json in jupyterlab_vre/component_containerizer/handlers.py#L263.

However, when creating a new release on NaaVRE-flavors, there is a ~45-minutes window during which https://github.com/QCDIS/NaaVRE-flavors/releases/latest/download/base_image_tags.json points to an empty document. When creating a release, we do:

Create the release (changes where https://github.com/QCDIS/NaaVRE-flavors/releases/latest/ points to)
Build all images (~45 minutes)
Generate base_image_tags.json and add it to the release

Possible solutions:

always set BASE_IMAGE_TAGS_URL in deployments
ship a version of https://github.com/QCDIS/NaaVRE-flavors/releases/latest/download/base_image_tags.json in the naavre-jupyter docker images and use this as fallback

gpelouze commented 2 months ago

We always set BASE_IMAGE_TAGS_URL in deployments to point it to a specific version eg. https://github.com/QCDIS/NaaVRE-flavors/releases/download/v0.14/base_image_tags.json