QCHackers / tqec

Design automation software tools for Topological Quantum Error Correction
https://qchackers.github.io/tqec/
Apache License 2.0
60 stars 17 forks source link

[Rev. Task 2] Copy constellation qubits from the footprint, not the #225

Closed smburdick closed 4 months ago

smburdick commented 4 months ago

Is your feature request related to a problem? Please describe. When I specify the footprint, it should copy the qubits

Describe the solution you'd like Instead of copying from the top-left corner, copy outward from where the footprint was specified

Describe alternatives you've considered The current implementation copies from the top-right according to the footprint, when we should be copying outward (like a spiral) from the current footprint.

Additional context Refer to the revisited task flow.

afowler commented 4 months ago

To be clear, I don't think you have to do a spiral copy. You just need to make sure that when you copy, however you wish to do this copy, left to right top to bottom, or any other method, that qubits placed do not land on top of one another. This check should be done before you allow the user to save the footprint. Once a valid footprint has been saved, you can copy it across the screen however you like.

On Thu, May 9, 2024 at 12:59 PM Sam Burdick @.***> wrote:

Is your feature request related to a problem? Please describe. When I specify the footprint, it should copy the qubits

Describe the solution you'd like Instead of copying from the top-left corner, copy outward from where the footprint was specified

Describe alternatives you've considered The current implementation copies from the top-right according to the footprint, when we should be copying outward (like a spiral) from the current footprint.

Additional context Refer to the revisited task flow.

— Reply to this email directly, view it on GitHub https://github.com/QCHackers/tqec/issues/225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAXTCVAUL4KID5DOBCLUTZBPISLAVCNFSM6AAAAABHPM4ERCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DQMZWGA2TMOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

smburdick commented 4 months ago

In that case, I will close this issue and stick with #219 .