search

QCoDeS / Qcodes_contrib_drivers

A collection of community-contributed QCoDeS drivers for instruments
https://qcodes.github.io/Qcodes_contrib_drivers/
MIT License
46 stars 84 forks source link

Tektronix/AFG3000: use MultiType with combiner argument #168

Closed jakeogh closed 2 years ago

jakeogh commented 2 years ago

Apply https://github.com/QCoDeS/Qcodes/pull/3917 closes #115

codecov-commenter commented 2 years ago

Codecov Report

Merging #168 (6c89a14) into master (a34b69f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   18.80%   18.80%           
=======================================
  Files         123      123           
  Lines       15581    15581           
=======================================
  Hits         2930     2930           
  Misses      12651    12651
Impacted Files Coverage Δ
...codes_contrib_drivers/drivers/Tektronix/AFG3000.py 0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jenshnielsen commented 2 years ago

Thanks, As far as I can see the is was added in qcodes 0.33.0 can you increase the minimum version here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/master/setup.cfg#L33 to match that (from 0.29.0)