search

QCoDeS / Qcodes_contrib_drivers

A collection of community-contributed QCoDeS drivers for instruments
https://qcodes.github.io/Qcodes_contrib_drivers/
MIT License
46 stars 81 forks source link

Sync multiple QDAC-IIs together #180

Closed jpsecher closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #180 (80df4cf) into main (ba7900b) will increase coverage by 1.84%. The diff coverage is 97.08%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   19.38%   21.23%   +1.84%     
==========================================
  Files         126      130       +4     
  Lines       15701    16083     +382     
==========================================
+ Hits         3044     3415     +371     
- Misses      12657    12668      +11
Impacted Files Coverage Δ
...contrib_drivers/tests/QDevil/test_sim_qdac2_awg.py 100.00% <ø> (ø)
...drivers/tests/QDevil/test_sim_qdac2_source_list.py 100.00% <ø> (ø)
...rivers/tests/QDevil/test_sim_qdac2_source_sweep.py 100.00% <ø> (ø)
...ib_drivers/tests/QDevil/test_sim_qdac2_triggers.py 100.00% <ø> (ø)
...ivers/tests/QDevil/test_sim_qdac2_virtual_gates.py 100.00% <ø> (ø)
...contrib_drivers/tests/QDevil/sim_qdac2_fixtures.py 78.12% <75.86%> (-1.88%) :arrow_down:
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.34% <92.20%> (-0.11%) :arrow_down:
...odes_contrib_drivers/drivers/QDevil/QDAC2_Array.py 98.57% <98.57%> (ø)
...rs/tests/QDevil/test_sim_qdac2_abstract_channel.py 100.00% <100.00%> (ø)
...drivers/tests/QDevil/test_sim_qdac2_arrangement.py 100.00% <100.00%> (ø)
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jpsecher commented 1 year ago

So I guess I am ready for release.

The driver for multiple QDACs does not yet behave as a proper Visa instrument, and I will work on an update later when I figure out the most compatible way to achieve that. But I think it is important that we have release now so that people can start using the synchronisation feature.

astafan8 commented 1 year ago

@jpsecher could you merge the latest greatest main into your branch? then the PR will merge itself