QCoDeS / Qcodes_contrib_drivers

A collection of community-contributed QCoDeS drivers for instruments
https://qcodes.github.io/Qcodes_contrib_drivers/
MIT License
46 stars 81 forks source link

Add QDevil QDAC 1 driver imported from Qcodes #196

Closed jenshnielsen closed 1 year ago

jenshnielsen commented 1 year ago

For reference the export was done with

git-filter-repo.cmd --path qcodes/instrument_drivers/QDevil/ --path-rename qcodes/instrument_drivers/:qcodes_contrib_drivers/drivers/ --tag-rename '':'qcodes-'

Which was then merged with a local remote into this repo

closes https://github.com/QCoDeS/Qcodes_contrib_drivers/issues/194

codecov-commenter commented 1 year ago

Codecov Report

Merging #196 (44c366f) into main (64a668e) will decrease coverage by 0.58%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   21.23%   20.64%   -0.59%     
==========================================
  Files         130      131       +1     
  Lines       16083    16540     +457     
==========================================
  Hits         3415     3415              
- Misses      12668    13125     +457     
Impacted Files Coverage Δ
...odes_contrib_drivers/drivers/QDevil/QDevil_QDAC.py 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jenshnielsen commented 1 year ago

@jpsecher FYI

jpsecher commented 1 year ago

Would it make sense to name it Qcodes_contrib_drivers/qcodes_contrib_drivers/drivers/QDevil/QDAC1.py to be in line with the other driver and to avoid confusion?

jenshnielsen commented 1 year ago

@jpsecher Done