QCoDeS / Qcodes_contrib_drivers

A collection of community-contributed QCoDeS drivers for instruments
https://qcodes.github.io/Qcodes_contrib_drivers/
MIT License
46 stars 84 forks source link

QDAC1: Allow slopes greater than 10V #209

Closed jpsecher closed 1 year ago

jpsecher commented 1 year ago
- Handle excess output
- Report errors in complex commands
jpsecher commented 1 year ago

Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden...

If that is the case, the patch will make the driver somewhat unusable.

astafan8 commented 1 year ago

@jpsecher

Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden... If that is the case, the patch will make the driver somewhat unusable.

this is strange. note that the self.timeout parameter is in seconds, not in milliseconds (like self.visa_handle.timeout) - could that be the issue?

jpsecher commented 1 year ago

Of course it is in seconds (https://www.youtube.com/watch?v=QfnC_3Uxj2I)

So the value has to be divided by thousand. I am not sure how to do it here in Github though...

codecov-commenter commented 1 year ago

Codecov Report

Merging #209 (d6732ec) into main (11a8456) will decrease coverage by 0.04%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   20.64%   20.60%   -0.04%     
==========================================
  Files         134      134              
  Lines       16824    16852      +28     
==========================================
  Hits         3473     3473              
- Misses      13351    13379      +28     
Impacted Files Coverage Δ
qcodes_contrib_drivers/drivers/QDevil/QDAC1.py 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

astafan8 commented 1 year ago

@jpsecher i see that you managed to to change set_to to 0.001 - is everything working now? if so, let's merge?

astafan8 commented 1 year ago

@jpsecher could you merge the latest gratest main into your branch? then the Pr will be merged automatically