Closed jpsecher closed 1 year ago
Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden...
If that is the case, the patch will make the driver somewhat unusable.
@jpsecher
Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden... If that is the case, the patch will make the driver somewhat unusable.
this is strange. note that the self.timeout
parameter is in seconds, not in milliseconds (like self.visa_handle.timeout
) - could that be the issue?
Of course it is in seconds (https://www.youtube.com/watch?v=QfnC_3Uxj2I)
So the value has to be divided by thousand. I am not sure how to do it here in Github though...
Merging #209 (d6732ec) into main (11a8456) will decrease coverage by
0.04%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 20.64% 20.60% -0.04%
==========================================
Files 134 134
Lines 16824 16852 +28
==========================================
Hits 3473 3473
- Misses 13351 13379 +28
Impacted Files | Coverage Δ | |
---|---|---|
qcodes_contrib_drivers/drivers/QDevil/QDAC1.py | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@jpsecher i see that you managed to to change set_to to 0.001 - is everything working now? if so, let's merge?
@jpsecher could you merge the latest gratest main into your branch? then the Pr will be merged automatically