search

QCoDeS / Qcodes_contrib_drivers

A collection of community-contributed QCoDeS drivers for instruments
https://qcodes.github.io/Qcodes_contrib_drivers/
MIT License
46 stars 81 forks source link

Keithley 6430: Add appropriate lower limit for voltage compliance #297

Closed mgunyho closed 6 months ago

mgunyho commented 6 months ago

Hi!

We noticed a bug in this SMU driver: writing an SCPI command to set a voltage compliance value that is below the minimum accepted by the device (0.2 mV) will cause the value to be silently ignored, and the previous compliance level will stay. Without this modification, it is possible to set the compliance to 0.1 mV in QCoDeS but accidentally pass 20 V, since that is the default voltage compliance when the device is booted. This PR fixes this behavior.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.49%. Comparing base (537fb8e) to head (d088362).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #297 +/- ## ======================================= Coverage 11.49% 11.49% ======================================= Files 123 123 Lines 16745 16745 ======================================= Hits 1925 1925 Misses 14820 14820 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jenshnielsen commented 6 months ago

Thanks @mgunyho