Closed grahamking closed 3 years ago
Thanks a lot, @grahamking Could you make the naming more semantic, like "Format with rustfmt"
Sure can! I'll close this and open a different PR. Replaced with #3
OK, after some invasive branch surgery on my repo I think I have it all lined up. I've never submitted a PR that builds on another PR, so let me know if the second one (adding ':' support) is problematic. Thanks!
OK, after some invasive branch surgery on my repo I think I have it all lined up. I've never submitted a PR that builds on another PR, so let me know if the second one (adding ':' support) is problematic. Thanks!
The correct way to do this would be to make two different branches, so you can make your first commit and then checkout a new branch from that branch and make the next commit. Then, you can make the PRs and have it be dependent on one another.
A branch of a branch, that makes a lot of sense, thanks. And sorry for the mess I made of your PRs.
I'm porting kip to Rust (as an excuse to play with Rust). It uses INI files for config. I needed an INI parser with no dependencies, so I was very glad to find your project.
A branch of a branch, that makes a lot of sense, thanks. And sorry for the mess I made of your PRs.
I'm porting kip to Rust (as an excuse to play with Rust). It uses INI files for config. I needed an INI parser with no dependencies, so I was very glad to find your project.
That's pretty cool actually, I made this library as I was learning Rust and I found the current crates to have incomplete docs, so yeah. Glad to have you contribute! 😄
So that my actual changes don't get mixed into the formatting.