QEDjl-project / QEDbase.jl

[WIP] Base types and interfaces for QED.jl
https://qedjl-project.github.io/QEDbase.jl/stable/
MIT License
5 stars 5 forks source link

cross_section and probability interface exports #86

Closed AntonReinhard closed 2 months ago

AntonReinhard commented 3 months ago

Currently, QEDbase.jl exports the functions

However, it does not define them in any way. This is definitely an issue because they cannot be overridden (because they are undefined) but re-exporting them in a different package still creates a collision requiring a namespace qualifier to use them. The question is where to keep the implementations in the future. Right now they are in QEDprocesses.jl. The functions seem basic enough to be part of either QEDbase or QEDcore, and since they are in a way convenience functions based on top of an interface, I suggest moving them to QEDcore.

szabo137 commented 3 months ago

Oh, this should be added here because defining them anywhere else, would end up being type piracy in one way or another.

I will open a PR later today.

AntonReinhard commented 2 months ago

Solved with #87