search

QEDjl-project / QEDcore.jl

[WIP] Core types and functions for QED.jl
https://qedjl-project.github.io/QEDcore.jl/stable/
MIT License
0 stars 3 forks source link

Add functionality from QEDbase and QEDprocesses #6

Closed AntonReinhard closed 3 months ago

AntonReinhard commented 3 months ago

Adds most of the tests from QEDbase and has them working here. They should next be moved back to QEDbase using package extensions

CI_UNIT_PKG_URL_QEDbase: https://github.com/QEDjl-project/QEDbase.jl/tree/process_interfaces

szabo137 commented 3 months ago

The unit test pipelines fail because this PR depends on the movement of types from QEDprocesses.jl to QEDbase.jl, e.g. missing AbstractCoordinateSystem. To circumvent these kinds of meta-dependencies, I suggested a plan for the restructuring process here: https://github.com/QEDjl-project/QED.jl/issues/35

For this PR, I suggest removing every functionality from QEDprocesses.jl, i.e. phase_space and such. If you also use import QEDbase instead of using QEDbase (and correct the respective namespace takes), this one should work with the current dev branch of QEDbase.jl. We can now merge this one to dev (dev_refac should be unnecessary).

Then we can proceed with the schedule given here: https://github.com/QEDjl-project/QED.jl/issues/35

AntonReinhard commented 3 months ago

CI_UNIT_PKG_URL_QEDbase: https://github.com/QEDjl-project/QEDbase.jl/tree/process_interfaces