search

QEDjl-project / QEDprocesses.jl

[WIP]: QEDprocesses.jl: Modeling of scattering processes for QED.jl
MIT License
1 stars 3 forks source link

Introduce InPhaseSpacePoint #68

Closed AntonReinhard closed 1 month ago

AntonReinhard commented 1 month ago

This PR adds a type InPhaseSpacePoint, which is a partially specialized version of a PhaseSpacePoint. It can be used to dispatch in places where only the incoming part of a phase space is required. Construction of PhaseSpacePoints now allows empty tuples for either incoming or outgoing phase spaces.

Left to do:

AntonReinhard commented 1 month ago

It might be good to have some more tests for the generation of PSPs and InPSPs from coordinates. They're currently only tested through usage in other higher-level tests like the Compton tests, but it might be good to have some unit tests for them as well. I'm not completely sure how the generate_momenta actually works though, so it might be better if @szabo137 can do this?

AntonReinhard commented 1 month ago

@szabo137 Please review again and check if your comments are resolved