search

QEDjl-project / QEDprocesses.jl

[WIP]: QEDprocesses.jl: Modeling of scattering processes for QED.jl
MIT License
1 stars 3 forks source link

Remove interfaces and functionality that move #74

Closed AntonReinhard closed 4 days ago

AntonReinhard commented 3 weeks ago

The interfaces and functionality have moved to QEDbase and QEDcore.

szabo137 commented 1 week ago

@AntonReinhard Please update QEDbase and push again. What's needed to fix this?

Edit: Seems like QEDbase-compat is broken. Maybe rebasing would be good :)

AntonReinhard commented 1 week ago

@AntonReinhard Please update QEDbase and push again. What's needed to fix this?

Edit: Seems like QEDbase-compat is broken. Maybe rebasing would be good :)

This needs to be merged: https://github.com/QEDjl-project/QEDcore.jl/pull/25 and QEDcore needs to be released. The implementations of PhaseSpacePoint for example move there but aren't yet available.

AntonReinhard commented 1 week ago

Also, the QEDbase. replacements in QEDcore need to be removed again I think.

AntonReinhard commented 1 week ago

This builds and tests locally with the changes from https://github.com/QEDjl-project/QEDcore.jl/pull/29 and the dev-branch of QEDbase.

AntonReinhard commented 5 days ago

The doc building fails because for some reason it refuses to get QEDbase 0.2 instead of 0.1. I have no idea why.

AntonReinhard commented 5 days ago

The doc building fails because for some reason it refuses to get QEDbase 0.2 instead of 0.1. I have no idea why.

I found the problem. Should be ready for review now. @szabo137 ping