search

QEDjl-project / QEDprocesses.jl

[WIP]: QEDprocesses.jl: Modeling of scattering processes for QED.jl
MIT License
1 stars 3 forks source link

Remove abstract cs and probability implementations #87

Closed AntonReinhard closed 4 days ago

AntonReinhard commented 4 days ago

The implementations of the cross sections and probability functions for abstract processes have moved to QEDbase, see https://github.com/QEDjl-project/QEDbase.jl/pull/87. They are therefore now deleted here.

Fixes issue https://github.com/QEDjl-project/QEDbase.jl/issues/86

AntonReinhard commented 4 days ago

Thanks for the fast PR! Looks good for me. Will merge if the pipeline succeeds.

Edit: Oh, the tests, you are right 😅

Yes, almost forgot :sweat_smile: Should be good if the pipeline goes through :+1: Feel free to merge then.

Edit: Right, it won't succeed. It now needs the implementations from QEDbase. I think we need to target this branch in the QEDbase integration tests, then merge the QEDbase PR, then merge this one.

szabo137 commented 4 days ago

Thanks for the fast PR! Looks good for me. Will merge if the pipeline succeeds. Edit: Oh, the tests, you are right 😅

Yes, almost forgot 😅 Should be good if the pipeline goes through 👍 Feel free to merge then.

Edit: Right, it won't succeed. It now needs the implementations from QEDbase. I think we need to target this branch in the QEDbase integration tests, then merge the QEDbase PR, then merge this one.

Could you please add

CI_UNIT_PKG_URL_QEDbase: https://github.com/szabo137/QEDbase.jl#2492e986972de30fadd68cd7fa7946dc4d888a61

to your last commit message? Then the unit tests should succeed. If so, we can tell https://github.com/QEDjl-project/QEDbase.jl/pull/87 to use this fix here and merge it. Afterwards we can merge here.

AntonReinhard commented 4 days ago

Something seems to break with the pipeline. It finds and clones the correct QEDbase version, but somehow there seems to be a git merge happening in the Project.toml, leading to a parsing error

szabo137 commented 4 days ago

Something seems to break with the pipeline. It finds and clones the correct QEDbase version, but somehow there seems to be a git merge happening in the Project.toml, leading to a parsing error

My bad, wrong commit hash 🤦‍♂️ This is the correct one: fb4c800acc99ffe83efe558a5a094e63eed9abde

szabo137 commented 4 days ago

Please remove the CI_UNIT_PKG_URL_QEDbase from the last commit message and force push again.. this should use the current QEDbase#dev and therefore should pass the tests.