search

QEDjl-project / QuantumElectrodynamics.jl

[WIP] QuantumElectrodynamics.jl: A strong-field particle physics framework
https://qedjl-project.github.io/QuantumElectrodynamics.jl/
MIT License
10 stars 3 forks source link

Skip Pkg.develop for dev package #87

Closed AntonReinhard closed 2 weeks ago

AntonReinhard commented 2 weeks ago

This simply skips the Pkg.develop call for the package that is currently being developed. Trying to load it results in ERROR: LoadError: packageQEDbase [10e22c08]has the same name or UUID as the active project, see for example https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1518348313 . I'm not 100% sure this is the correct fix for the problem, please correct if I'm wrong @SimeonEhrig .

I made two test runs in base and core with this branch QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744 QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

And both seem to work fine.

Edit: Changed it so that it tries to install the dev package and catches the LoadError.

SimeonEhrig commented 2 weeks ago

Instead using try catch, I think it is better to compare with Pkg.project.name. I can image, the try catch approach could cause problems, because sometimes you want to uninstall and install QEDbase (actual QEDcore and higher in the dependency hierarchy -> QEDbase is a special case). For example, if you build the documentation, the package which is under development, is a real dependency of the doc environment.

SimeonEhrig commented 2 weeks ago

I made two test runs in base and core with this branch QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744 QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

Can you please link the PR's. I don't know how you did test.

AntonReinhard commented 2 weeks ago

I made two test runs in base and core with this branch QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744 QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

Can you please link the PR's. I don't know how you did test.

I only had these as temporary commits on existing branches because I didn't want to open new PRs everywhere. I reset them after the CI finished, so you can't see them anymore. They did not change anything other than the links to the QuantumElectrodynamics.jl repositories in the gitlab yaml and the github docs building workflow.

AntonReinhard commented 2 weeks ago

I'm closing this in favor of #88, which should be the more robust solution.