search

QF-Error-Tracking / QFVD5

0 stars 0 forks source link

Outputs: Not Seeing Fuel Second Vertical Layer #27

Closed zacharycope0 closed 9 months ago

zacharycope0 commented 11 months ago

Describe the bug I was running sims to analyze fire behavior in a shrub layer but I'm not seeing any fuel in the output's second vertical layer.

My treesrhof.dat file has a bulk density 0.5 in the first layer and 0.8 in the second layer. The plots of the output files match the input for first vertical layer but have values of zero for the second vertical later. I don't think made any mistakes with the inputs. I checked gridlist and QUIC_fire.inp to make sure my fuel grid matched the inputs.

Input 1st Vertical Layer: plot

Input 2nd Vertical Layer: plot

Input 1st Vertical Layer: fuel_dens_Time_0_s_Plane_1

Input 2nd Vertical Layer: fuel_dens_Time_0_s_Plane_2

To Reproduce https://drive.google.com/file/d/1GYxgDLMM8VKET9NAdkylE5IQuRMZ9Ub3/view?usp=share_link

Desktop (please complete the following information):

zacharycope0 commented 11 months ago

@ntutland. Do you mind double-checking the input files and running this simulation to confirm the bug? I'm very confused by this and want to make sure human error isn't involved.

ntutland commented 11 months ago

Sure no problem

ntutland commented 11 months ago

@zacharycope0 I am seeing the same thing. Are you using drawfire to plot the outputs? The plotting of horizontal slices in drawfire is defined by "plane"s, which seem to be 1-indexed, so I assume somewhere plane-1 is used to index the z-layers, but I can't find where. Do you think that could be part of the problem or are you pretty confident in those output plots?

zacharycope0 commented 11 months ago

@ntutland. Yeah, plane 2 is Python index 1 (the shrub layer). I'm using drawfire's import routine, but I looked at the outputs as numpy arrays and they have the shape and surface fuel I expect. Just no fuel in the second layer.

zacharycope0 commented 11 months ago

@drobinson6045 do you mind taking a look at this when you get a chance?

zacharycope0 commented 9 months ago

David found the issue

ntutland commented 9 months ago

Is it specific to this sim or should we make sure it is not affecting ours?

zacharycope0 commented 9 months ago

I resent David's email. He found a fix and thought the interpolation error only occurred for very specific sims: "I believe it just happened to be the case when you import custom fuels that are only 2 layers but I’m not absolutely certain at this point", David.