QGEP / qgepqwat2ili

3 stars 3 forks source link

Improve user feedback and speed-up interlis import qgep #141

Closed sjib closed 5 months ago

sjib commented 6 months ago

Datamodel - see https://github.com/QGEP/datamodel/pull/235/commits/1c9079167b8f5b2e92bf2a8cfe393955acac24b0

sjib commented 6 months ago

Should improve (I have added some logger info that it is still processing) https://github.com/QGEP/qgepqwat2ili/issues/119 - not yet best user experience, but already better

sjib commented 6 months ago

import_krattigen_dss_003_12052024_215355

It looks like the triggers are re-enable before the data is imported - the wizard is still open - see logging on screen shot.

@domi4484 Is this a similar error as you have found in TEKSI wastewater? https://github.com/teksi/wastewater/pull/211/files

How could the TEKSI improvment be backported to qgep?

domi4484 commented 6 months ago

@sjib Yes it seems similar. Basically you need to re-enable the triggers only after the dialog has been acceptedd/rejected.

By re-thinking on this we could have an issue (in TEKSI as well) if someone kills QGIS before the trigger are re-enabled they will remain disabled forever. Maybe we should add a check on startup of the plugin or some other mechanism to check if the trigger are enabled

sjib commented 5 months ago

With that the triggers are enabled after the import - this speeds up the import greatly (e.g. Testdata K from @urskaufmann in 3 minutes instead of 30 minutes or more).

This needs these datamodel changes 1.6.2 to work properly!

sjib commented 5 months ago

By re-thinking on this we could have an issue (in TEKSI as well) if someone kills QGIS before the trigger are re-enabled they will remain disabled forever. @domi4484 Glad to have you're review on my work - may be you can add your suggestions for this also in this.

sjib commented 5 months ago

@ponceta Ready for review and then merging - needs these https://github.com/QGEP/datamodel/pull/235 to work properly!