search

QGEP / qgepqwat2ili

3 stars 3 forks source link

fk_dataowner check not correct #176

Open sjib opened 3 weeks ago

sjib commented 3 weeks ago 
          Thanks for plugin 1.6.4.

Testing exports (these was blocking me in the last days): Export DSS_2015, no selection: no errors in the validation at the end, reachpoints are now exported with Abwassernetzelementref. Strange message while exporting: _2024-10-17T18:46:54 SUCCESS Sucess : OK: Integrity checks organisation 2024-10-17T18:46:54 SUCCESS Sucess : OK: Integrity checks wastewater_structure 2024-10-17T18:46:54 SUCCESS Sucess : OK: Integrity checks identifiers not isNull 2024-10-17T18:46:55 SUCCESS Sucess : OK: Integrity checks fk_owner not isNull 2024-10-17T18:46:55 SUCCESS Sucess : OK: Integrity checks fk_operator not isNull 2024-10-17T18:46:55 INFO INFO: Missing fk_dataowner in schema qgep_od : Add missing fk_dataowner to get a valid INTERLIS export file when converting to Release 2020 (will bei MANDATORY). See qgep logs tab for details. 2024-10-17T18:46:55 INFO INFO: Missing fk_provider in schema qgep_od : Add missing fkprovider to get a valid INTERLIS export file when converting to Release 2020 (will bei MANDATORY). See qgep logs tab for details. 2024-10-17T18:50:40 SUCCESS Sucess : Data successfully exported to P:/Thun/Gemeinden/166-167 Unterlangenegg/qgep/exporte/qgep-export2024-10-17 First SUCCESS OK, then Info about missing fk_dataowner. I checked the XTF-File: there are as many as records exported, so I think this Info is fake

Originally posted by @urskaufmann in https://github.com/QGEP/QGEP/issues/880#issuecomment-2420084597

sjib commented 3 weeks ago

@urskaufmann Should I just change the final message if fk_provider and / or fk_datawoner are missing? Or should I also stop the export as with missing fk_owner / fk_operator?

What do the others think?

sjib commented 3 weeks ago

https://github.com/QGEP/qgepqwat2ili/blob/7372cb27e5cfaa7ec6b5f78f3f756666d7589243/qgepqwat2ili/gui/__init__.py#L786

And additional condition criteria would have to be added here if fk_provider and / or fk_dataowner are not complete

urskaufmann commented 3 weeks ago

I have now realized what the message is about... you have to really really read the text!

I would not stop the export. I would place this Note at the end of the export. Not starting with "Missing..." but something like: When converting to release 2020, fk_dataowner/fk_provider will be mandatory, but are missing in this export.