search

QGEP / qgepqwat2ili

3 stars 3 forks source link

Documentation of tests missing #85

Closed sjib closed 1 year ago

sjib commented 1 year ago

Please describe the tests and the used testdata

It looks like some testdata is intended to create failures - but then tests are not running thru: test_qgep py

is this intended or not?

Currently code cannot be checked in without errors - see e.g. https://github.com/QGEP/qgepqwat2ili/pull/84

olivierdalang commented 1 year ago

If I remember correctly, this is because the input XTF we had to test import at the time of implementing this was not valid (according to ilivalidator). If we have a better file now (ideally something a shareable real-world like file), it would be good to use it instead of case_c_import_all.xtf and remove the @unittest.expectedFailure line

sjib commented 1 year ago

See https://github.com/QGEP/qgepqwat2ili/pull/84#issuecomment-1380886261