round-by-round rigid registration has misleading field name

QI2lab / merfish3d-analysis

3D MERFISH data processing

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

round-by-round rigid registration has misleading field name #6

Closed mcschweiger closed 3 months ago

mcschweiger commented 4 months ago

wf-merfish version: 0.1.2
Python version: 3.10.14
Operating System: Ubuntu 22.04

Description

I am incorporating the registration parameters from your processed data into my own analysis of small crops of your data.

Within the polyDT channel, the field name for this registration parameter is 'rigid_xyz_um', suggesting it has units of microns. It appears that this registration parameter is in fact in pixels.

Can you clarify or change the notation to avoid confusion?

dpshepherd commented 3 months ago

Done, renamed to rigid_xyz_px. Also added _px to the optical flow to make sure all transforms have appropriate units.