search

QIDITECH / QIDISlicer

QIDISlicer gets your 3D printing easier and faster.
https://qidi3d.com/
GNU Affero General Public License v3.0
40 stars 10 forks source link

Prusa Slicer License attributions were incorrectly removed #53

Open stew675 opened 3 months ago

stew675 commented 3 months ago

In this PR change set here: https://github.com/QIDITECH/QIDISlicer/commit/cad0b137b44e0073d8b79751b83027060ad5716a

It looks like someone did a blanket find/replace of Prusa for Qidi that looks like it was intended to catch variable names in the source code, but applied it so thoroughly that it ended up editing out the Open Source Licensing Attribution in the About file here: https://github.com/QIDITECH/QIDISlicer/blame/516d3a3313f4fde306f918f7a36207bf5f98d42b/src/slic3r/GUI/AboutDialog.cpp#L279

Items like this should be corrected as it is causing negative discussion in the community that Qidi is not correctly PrusaSlicer in the licensing attributions.

QIDITECH commented 3 months ago

I'm very sorry, this is our mistake, we have modified and re-uploaded the code. The released version 1.1.2 will not be modified, and re-uploading files may cause some customers to be unable to update online. The problem will not be closed, it will remind us not to make the same mistake again.

stew675 commented 3 months ago

Thank you for the reply and fast fix in good faith.

You may also want to look over that pr https://github.com/QIDITECH/QIDISlicer/commit/cad0b137b44e0073d8b79751b83027060ad5716a in more detail. It looks like a number of web links to the Prusa Knowledge database also got scribbled over, and since Qidi does not have an equivalent web version of that database, most of those Knowledge Database links now point to nowhere, and are consequently broken.

QIDITECH commented 3 months ago

Yes, we will gradually improve everything, but it will take some time.