QIDITECH / QIDI_Q1_Pro

GNU Affero General Public License v3.0
29 stars 3 forks source link

Consider bundling mobileraker companion #62

Open wrobelda opened 3 weeks ago

wrobelda commented 3 weeks ago

I can see you use kiauh for building Klipper and other components, so I would suggest that you also bundle the mobileraker companion by default. I am aware you have your own mobile app, but some definitely prefer to use mobileraker, so I suppose bundling and adding it commented out in moonraker.conf would do the job?

CChen616 commented 3 weeks ago

Due to Mobileraker's license prohibiting commercial use, we have decided not to install the software by default to avoid any risks.

We recommend that users who need it choose and configure it themselves to ensure compliance with their own needs and usage terms.

wrobelda commented 3 weeks ago

I'm not sure I follow, the mobileraker-companion is licensed with a permissive MIT, which allows for unrestricted commercial use?

For the record, the companion software allows Mobileraker users to receive push notifications on their phone: https://github.com/Clon1998/mobileraker_companion

To get it to work it requires some Python modules, which in turn require zlib and libjpeg installed.

CChen616 commented 3 weeks ago

I mistakenly thought https://github.com/Clon1998/mobileraker was the plugin you recommended. Mobileraker_companion, serving as the client, does allow commercial use.

Considering the following points, we might still decide not to include this plugin in the default bundle: