search

QIICR / QuantitativeReporting

Segmentation-based measurements with DICOM import and export of the results.
https://qiicr.gitbooks.io/quantitativereporting-guide
Other
23 stars 23 forks source link

tid1500 plugin loading error #243

Closed pieper closed 5 years ago

pieper commented 5 years ago

Testing #240 with QR extension build from today on nightly.

Traceback (most recent call last):
  File "/private/tmp/Slicer.app/Contents/lib/Slicer-4.11/qt-scripted-modules/DICOMLib/DICOMWidgets.py", line 730, in getLoadablesFromFileLists
    loadablesByPlugin[plugin] = plugin.examineForImport(fileLists)
  File "/private/tmp/Slicer.app/Contents/Extensions-28388/QuantitativeReporting/lib/Slicer-4.11/qt-scripted-modules/base/DICOMPluginBase.py", line 53, in examineForImport
    loadablesForFiles = self.examineFiles(files)
  File "/private/tmp/Slicer.app/Contents/Extensions-28388/QuantitativeReporting/lib/Slicer-4.11/qt-scripted-modules/DICOMTID1500Plugin.py", line 32, in examineFiles
    uid = self.getDICOMValue(dataset, "SOPInstanceUID")
  File "/private/tmp/Slicer.app/Contents/Extensions-28388/SlicerDevelopmentToolbox/lib/Slicer-4.11/qt-scripted-modules/SlicerDevelopmentToolboxUtils/decorators.py", line 194, in __call__
    raise TypeError("no match for types %s" % str(types))
TypeError: no match for types ('FileDataset', 'str')
Warning: Plugin failed: DICOMTID1500Plugin

See python console for error message.
fedorov commented 5 years ago

I cannot reproduce this error. I tried, and could load a CT image with the TID1500 plugin enabled, and without any errors in the log.

Can you share the dataset, or give more details on the steps to reproduce?

pieper commented 5 years ago

As with #240 this happens on the nightly.

fedorov commented 5 years ago

Should be fixed in https://github.com/QIICR/SlicerDevelopmentToolbox/commit/407d02f5e2e4e7802f60df75e249c75e55a674e7

pieper commented 5 years ago

Fixed - thank you!