Running tests requiring measurement to be saved are blocking.

QIICR / QuantitativeReporting

Segmentation-based measurements with DICOM import and export of the results.

https://qiicr.gitbooks.io/quantitativereporting-guide

Other

23 stars 23 forks source link

Running tests requiring measurement to be saved are blocking. #257

Closed jcfr closed 3 years ago

jcfr commented 3 years ago

Running tests requiring measurement saving are blocking.

https://github.com/QIICR/QuantitativeReporting/blob/962ed63cc84d943db95076e6320e33a19e661026/QuantitativeReporting/QuantitativeReporting.py#L90-L96

Steps to reproduce

ctest -R QuantitativeReportingTests

Screenshot captured on "overload" windows dashboard:

Expected behavior

User interaction should not be expected when running Slicer dashboard

Environment

Slicer version: Slicer-4.13 Slicer/Slicer@4ec6541a620aa24559f70c65d363c1da3682902a
Operating system: NA

jcfr commented 3 years ago

cc: @sjh26 @lassoan @pieper

fedorov commented 3 years ago

Is this something that should be handled better by Slicer applicationLogic, in the testing framework, or fixed in QR?

It might be that most intuitive way to fix this is be to populate user name with some default value, and prompt the user to change it when the application is launched for the first time.

pieper commented 3 years ago

Our traditional approach is not to use blocking dialogs when in test mode, so updating QR would be most convenient.

On the other hand having a default value of something like "Not Specified" for the user and similar field is what I do in other code.