QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
241 stars 61 forks source link

COMP: Fix Slicer extension packaging #310

Closed jcfr closed 7 years ago

jcfr commented 7 years ago

Setting CPACK_INSTALL_CMAKE_PROJECTS variable became a requirement following Slicer r25181. That said extensions only started to fail packaging recently because fix introduced in r25181 was made effective after Slicer r26488.

See https://discourse.slicer.org/t/extension-build-failures/1274/4

r25181: BUG: Extension packaging: For SuperBuild extension, ensure fixup happens last r26488: COMP: Ensure 3rd libs and binaries are fixed up for SuperBuild extensions

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25181 http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=26488

Reported-by: Andriy Fedorov fedorov@bwh.harvard.edu

codecov[bot] commented 7 years ago

Codecov Report

Merging #310 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files          28       28           
  Lines        2334     2334           
=======================================
  Hits         1847     1847           
  Misses        487      487

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4b1fb...b505bca. Read the comment docs.

fedorov commented 7 years ago

Thank you JC! Sorry if this is something we missed to fix based on forum announcements.

jcfr commented 7 years ago

Sorry if this is something we missed to fix based on forum announcements

No worry. This had to be fixed.

At least now, following r26550 a configure error will be report for other developer.