search

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
241 stars 61 forks source link

ci_addons packaging script is broken #349

Closed fedorov closed 6 years ago

fedorov commented 6 years ago

After an unrelated commit, it turns out ci_addons stopped working, at least on Appveyor. cc: @jcfr.

Appveyor: https://ci.appveyor.com/project/fedorov/dcmqi/build/0.0.1073

image

fedorov commented 6 years ago

@jcfr thanks for looking into this! 👍

jcfr commented 6 years ago

This is fixed by https://github.com/scikit-build/scikit-ci-addons/pull/72, as soon as the associated CI returns green, I will merged and create a new release of the package.

jcfr commented 6 years ago

I expect this to be fixed, I re-triggered the build: https://ci.appveyor.com/project/fedorov/dcmqi/build/0.0.1076

If it succeeds, I will close this issue

jcfr commented 6 years ago

I also re-triggered the build on CircleCI and TravisCI

fedorov commented 6 years ago

JC, I reverted that commit, it used a C++11 feature that was failing on some compilers independently from the packaging issue.

jcfr commented 6 years ago

Gotcha. I am closing for now. Please, re-open if there are still issues and I gladly fix them.

fedorov commented 6 years ago

Sorry, I thought that this packaging issue was independent from the compile error. I will reopen if I see it again. Thanks.