search

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results
https://qiicr.gitbook.io/dcmqi-guide/
BSD 3-Clause "New" or "Revised" License
242 stars 61 forks source link

Replaced the SRT codes with SCT codes #393

Closed afshinmessiah closed 4 years ago

afshinmessiah commented 4 years ago

Ref issue #386. Replaced all SRT codes in any text files of the project (.cpp, .h, .json, .py, ..).

fedorov commented 4 years ago

For completeness, can you put the script you use to do the substitution in the util folder?

fedorov commented 4 years ago

For the reference, and to link things together, this PR is aiming to resolve issue #386.

fedorov commented 4 years ago

Also, for commits like below:

image

it is better to squash them into a single commit, to keep history more concise.

fedorov commented 4 years ago

@afshinmessiah can you clean up the commit history a bit? I think the three commits starting with "Added the PYTHON script for replace srt wiht" can be merged into a single one, and also there are typos in the commit messages. You can read how to do this here: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History (just be careful!).

afshinmessiah commented 4 years ago

Sure @fedorov, just did. Can't figure why appveyor fails.

fedorov commented 4 years ago

There is a merge conflict for this PR - this might be the reason why appveyor complains.